Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Add 'env' field to IQE CJI spec #855

Merged
merged 8 commits into from
Sep 12, 2023
Merged

[RFR] Add 'env' field to IQE CJI spec #855

merged 8 commits into from
Sep 12, 2023

Conversation

bsquizz
Copy link
Contributor

@bsquizz bsquizz commented Sep 7, 2023

Adds an env field to the IQE CJI spec which allows anyone invoking a CJI to set a list of EnvVars that will be passed on to the IQE Job pod.

We will mark most of the fields that Clowder has been parsing and setting on the Job's pod here as deprecated and instead we'll begin to have the bonfire IQE CJI template define the structure of these env vars itself. We will also need to make sure anyone invoking a CJI without using bonfire updates their resource config before we remove the deprecated fields.

At the moment while both the "old fields" and the "new" env field exist, the behavior will be:

  1. First parse and set the env vars as we currently do in the code
  2. Add any vars set in env to the array
  3. If the name of any vars in env conflict with those already set in step 1, we will override whatever is currently set in the array and use the value defined in the env block.

@bsquizz bsquizz changed the title [WIP] Add 'env' field to IQE CJI spec Add 'env' field to IQE CJI spec Sep 8, 2023
@bsquizz bsquizz changed the title Add 'env' field to IQE CJI spec [RFR] Add 'env' field to IQE CJI spec Sep 11, 2023
@psav psav merged commit 7eef6ce into master Sep 12, 2023
2 checks passed
@psav psav deleted the iqe_cji_env_vars branch February 20, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants