Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not validate FEC config for build with custom webpack config. #1951

Conversation

Hyperkid123
Copy link
Contributor

Jira: https://issues.redhat.com/browse/RHCLOUD-28860

fec.config.js validation for runs with custom webpack config is not necessary because the values from the config file are not used.

The static command uses an entirely custom configuration.

@Hyperkid123 Hyperkid123 requested a review from a team January 3, 2024 10:07
@Hyperkid123 Hyperkid123 added bug Something isn't working release Once merged it will trigger bugfix release labels Jan 3, 2024
@karelhala karelhala merged commit d470e69 into RedHatInsights:master Jan 4, 2024
3 checks passed
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

        :package:@redhat-cloud-services/frontend-components-config/v/6.0.7📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Jan 4, 2024
@Hyperkid123 Hyperkid123 deleted the do-not-validate-fec-custom-webpack branch January 5, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants