Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RHINENG-8385): Make group filter look correct #2084

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(RHINENG-8385): Make group filter look correct #2084

merged 1 commit into from
Oct 24, 2024

Conversation

LightOfHeaven1994
Copy link
Contributor

Fixed size of group filter and adapted it to typeahead variant when search is available
Before:
image

After:
image

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the RHINENG-8385 branch 3 times, most recently from 0d23722 to ed01328 Compare October 24, 2024 04:46
adonispuente
adonispuente approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@adonispuente adonispuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a comment about adding a note but its not necessary.

packages/components/src/ConditionalFilter/GroupFilter.tsx Show resolved Hide resolved
@LightOfHeaven1994 LightOfHeaven1994 merged commit 32969ae into RedHatInsights:master Oct 24, 2024
1 check passed
@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label Oct 25, 2024
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

         :package:@redhat-cloud-services/frontend-components/v/4.2.19📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonispuente adonispuente adonispuente approved these changes

Assignees
No one assigned
Labels
release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LightOfHeaven1994 @nacho-bot @adonispuente @Hyperkid123