Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for RHEL8 nodes #181

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

Victoremepunto
Copy link
Collaborator

@Victoremepunto Victoremepunto commented Jul 15, 2024

  • change paths to avoid writing to the to the root filesystem
  • shellcheck formatting

Copy link

@wcmitchell wcmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! I'm assuming that pr_check.sh will run in the context of $HOME so it hits the right ~/container_workspace dir even though we don't explicitly cd there as we do in pr_check_inner.sh

@Victoremepunto
Copy link
Collaborator Author

👍 Looks good to me! I'm assuming that pr_check.sh will run in the context of $HOME so it hits the right ~/container_workspace dir even though we don't explicitly cd there as we do in pr_check_inner.sh

I'm changing it to be $HOME/container_workspace (from /container_workspace) so that the (non-root) user is able to write (and create) that dir. All references to this new directory are changed to that effect (if something still refers to it by its absolute location it will fail)

@adamrdrew adamrdrew merged commit 323a919 into RedHatInsights:main Jul 15, 2024
9 checks passed
@Victoremepunto Victoremepunto deleted the fix-dockerfile branch July 15, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants