refactor-lint #188
Merged
refactor-lint #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Victoremepunto
force-pushed
the
refactor-lint
branch
from
8837f3d
to
d6038fa
Compare
|
fixes introduced should solve the issues raised by the linter, however we're hitting a known bug from gosec, one of the linters used. golangci-lint needs to release a new version with the fix. see this |
Victoremepunto
force-pushed
the
refactor-lint
branch
from
f27ee96
to
edc744e
Compare
Victoremepunto
requested review from
psav and
adamrdrew
and removed request for
psav
Ok, unfortunately, the latest release didn't help and the linter keeps shouting about G115 - I've disabled it, if only temporarily, to move on and get this merged - I'm leaving the fix in though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to:
UPDATE: need to disable G115 from
gosecsince the linter still complains after applying and apparently valid fix. will revisit as securego/gosec#1212 gets fixed