Enable nested navigation templating. #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florkbr
reviewed
Dec 11, 2024
| // currently max known depth is 2, so 10 should be more than enough for ever | ||
| // event the depth 2 is challenging when it comes to UX, this should prevent infinite reference loops | ||
| if depth > 10 { | ||
| return parsedNavItems, fmt.Errorf("maximum navigation depth reached") |
There was a problem hiding this comment.
@Hyperkid123 I think this limitation seems reasonable - though we should write this in our migration guide.
Past that - can we add a test that exercises that this limitation/error is correctly exercised? Otherwise LGTM
There was a problem hiding this comment.
Oh yeah. I'll add the test.
Hyperkid123
force-pushed
the
nested-navigation
branch
from
cf7efe7 to
70f6d15
Compare
Hyperkid123
force-pushed
the
nested-navigation
branch
from
70f6d15 to
88c5902
Compare
florkbr
reviewed
Dec 11, 2024
| duration = time.Second * 10 | ||
| interval = time.Millisecond * 250 | ||
| ) | ||
| ginkgo.It("Should stop navigation nesting if the limit is exceeded", func() { |
There was a problem hiding this comment.
Perfect! Thanks @Hyperkid123
florkbr
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/RHCLOUD-36560
The Jira has links to docs and detailed explanations.
TLDR
A small number of UI modules are injecting navigation items into navigation segments that are not owned by the UI module itself. We need a templating mechanism that allows navigation segments to be injected across different modules.
Trying to do that with some paths/ordering attributes will result in many conflicts and complexity. Allowing explicit templating should make the code stable and configuration easier to understand for developers.