Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KSQLDB Source Tables #127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rodgers-mmsi
Copy link

The current implementation does not support creating source tables - i.e. CREATE TABLE statements that have the "SOURCE" clause. See here for details.

So, for example, if you have a source table defined as this:

CREATE SOURCE TABLE other_status_codes (code int primary key, definition varchar)
    with (kafka_topic = 'other_status_codes', value_format = 'json');

The pipelineExecute task succeeds the first time only. Running the pipelineExecute task a second time does not succeed - giving an error that the table "other_status_codes" exists. The task did not generate a DROP TABLE statement in the script.

Fair warning - I'm not a Groovy developer, so this may not be the most elegant way to fix the plugin, but it works, similar to the existing handling of source/sink connectors.

@stewartbryson
Copy link
Member

/gcbrun

@stewartbryson
Copy link
Member

@rodgers-mmsi Sorry this got passed me. If you are still interested in me merging this, can you merge the latest changes into your branch?

@stewartbryson
Copy link
Member

Received this error during unit tests:

Caused by: org.gradle.api.GradleException: error_code: 40001: line 1:15: mismatched input 'TABLE' expecting 'CONNECTOR'

@stewartbryson
Copy link
Member

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants