A few fixes and enhancements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use env(1) to find python executable instead of hardcoding the path of /usr/bin/python
* HTML Entity encode header keys and values - these can be malicious data
|
Dude, that's awesome, really smart, and funny. Ha, thanks for doing that. Checking it out now. |
|
Awesome, works great, and thanks for fixing the other stuff as well. This is a really funny instance, and showed a couple friends that you did that, and got a good laugh (embedding XSS in the server header value). Thanks again for the patch, really appreciate it. |
ChrisTruncer
added a commit
that referenced
this pull request
Feb 27, 2014
A few fixes and enhancements
|
Added extra notes to commit log and CHANGELOG calling you out for submitting the update to me. Thanks man. |
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few things that I noticed immediately when running against https://neg9.org/ - I have XSS in the Server: header value, which popped up in the report for this tool.
Future: Cleanup unicode handling (replacing u'blah' with blah and such?)