Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager validity dates restrictions + Add booking date validation (didn’t exist before) #213

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

folix-01
Copy link
Member

@folix-01 folix-01 commented Aug 19, 2024

  • Add possibility to restrict also a Bookings Manager by the validity dates of a Booking Folder.
  • Add validity dates checks during the booking creation. Actually is not considered so u can create booking for the every date you want

@coveralls
Copy link

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10924844787

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 32 of 33 (96.97%) changed or added relevant lines in 3 files are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.09%) to 75.154%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/prenotazioni/adapters/booker.py 10 11 90.91%
Files with Coverage Reduction New Missed Lines %
src/redturtle/prenotazioni/restapi/services/booking/notify_about_confirm.py 4 84.0%
src/redturtle/prenotazioni/browser/prenotazioni_context_state.py 5 86.38%
src/redturtle/prenotazioni/utilities/dateutils.py 8 51.02%
src/redturtle/prenotazioni/behaviors/booking_folder/notifications/email/events.py 8 85.29%
Totals Coverage Status
Change from base Build 10504574396: -0.09%
Covered Lines: 4017
Relevant Lines: 5345

💛 - Coveralls

@folix-01 folix-01 requested a review from mamico August 22, 2024 12:21
@folix-01 folix-01 self-assigned this Aug 26, 2024
@folix-01 folix-01 changed the title Manager validity dates restrictions + Add validity dates controls (didn’t exist before) Manager validity dates restrictions + Add validity dates validation (didn’t exist before) Sep 18, 2024
@folix-01 folix-01 changed the title Manager validity dates restrictions + Add validity dates validation (didn’t exist before) Manager validity dates restrictions + Add booking date validation (didn’t exist before) Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants