-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final Pull request for the File upload system #24
Conversation
….txt to support the ETL script.
@kghdxx Great work on the File Upload System! Your changes have significantly improved the functionality and overall structure of the application. The implementation of tabs in the Streamlit frontend, the ETL pipeline improvements, and the Flask API integration are all solid enhancements. It would protect sensitive data in the MinIO buckets from unauthorized access. Consider implementing: User authentication for the Streamlit frontend These additions would take your already good implementation to the next level in terms of security best practices. |
Hey Amir, as always this feedback is very valuable. I won't get the opportunity to implement the security features as leader this trimester but I will note these down as tasks for the next leader next trimester as part of handover. Cheers! |
hey Kghdxx , you absolutelynailed everything and i appreciate your hard work and dedication . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this, great work.
Added the functionality of tabs to the streamlit app.
The app now functions with the ability to store data on the VM, preprocess it with a number of choices, view the data in the VM and download either the original or the preprocessed out again and if needed save over the file in the VM after changes. works with .CSV.
Uses a flask API and python script to download and perform ETL bronze bucket (unprocessed data) is private on the minio server needing access keys to access.
These are stored in a .env file which has been omitted, as well as any hardcoded passwords.