Skip to content

Commit

Permalink
docker removal - comments
Browse files Browse the repository at this point in the history
  • Loading branch information
chayim committed May 23, 2021
1 parent 4649986 commit ce54a7f
Showing 1 changed file with 2 additions and 30 deletions.
32 changes: 2 additions & 30 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,26 +71,12 @@ commands:
- ~/.cache/pip
key: v1-dependencies-{{ checksum "pyproject.toml" }}

docker:
parameters:
docker_version:
type: string
default: "edge"
steps:
- setup_remote_docker
- run:
name: dockers
description: Build and release docker
command: |
docker login -u redisfab -p $DOCKER_REDISFAB_PWD
docker build -t redisai-py:<<parameters.docker_version>> .
docker push
jobs:
build:
parameters:
python_version:
type: string
default: "latest"
docker:
- image: circleci/python:<<parameters.python_version>>
- image: redislabs/redisai:edge-cpu-bionic
Expand All @@ -101,20 +87,6 @@ jobs:
path: test-reports
destination: test-reports

# since this is used by cron, we by default build against latest
build_and_publish:
parameters:
docker_version:
type: string
default: "edge"
docker:
- image: circleci/python:latest
- image: redislabs/rediai:edge-cpu-bionic

steps:
- build_and_test
- docker

nightly:
parameters:
python_version:
Expand Down Expand Up @@ -164,4 +136,4 @@ workflows:
cron: "0 0 * * *"
<<: *on-master
jobs:
- build_and_publish
- build

0 comments on commit ce54a7f

Please sign in to comment.