[WIP] Pipeline command #41
Conversation
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 98.41% 97.10% -1.31%
==========================================
Files 5 6 +1
Lines 567 656 +89
==========================================
+ Hits 558 637 +79
- Misses 9 19 +10
Continue to review full report at Codecov.
|
|
This pull request introduces 2 alerts when merging 168c4a5 into 4918068 - view on LGTM.com new alerts:
|
|
|
| meta_only=meta_only)) | ||
| return super().tensorget(key, as_numpy, meta_only) | ||
|
|
||
| def _execute_transaction(self, *args, **kwargs): |
There was a problem hiding this comment.
FYI, transactions won't work on blocking commands, ie MODELRUN, SCRIPTRUN and DAGRUN. Not sure we want to catch this during pipeline creation or let Redis complain.
There was a problem hiding this comment.
Never knew! Thanks
I'll let the Redis complain, for now (I have added a #TODO to consider this later). Since the API is experimental, I assume that's fine
|
Looks great! |
|
Thanks @lantiga, merging it |
|
This pull request introduces 2 alerts when merging cbae7d5 into 4918068 - view on LGTM.com new alerts:
|
Making pipelining possible with redisai commands as well