Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dial options #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

damikem
Copy link

@damikem damikem commented Oct 20, 2020

add options for dial when connecting to Redis (allowing to control options such as read/write/connect timeout, keep alive and more)

mikedavidson added 2 commits October 20, 2020 16:17
…tions such as read/write/connect timeout, keep alive and more)
…tions such as read/write/connect timeout, keep alive and more)
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #27 (5675347) into master (3da966a) will increase coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   86.84%   86.89%   +0.04%     
==========================================
  Files           2        2              
  Lines         266      267       +1     
==========================================
+ Hits          231      232       +1     
  Misses         20       20              
  Partials       15       15              
Impacted Files Coverage Δ
client.go 89.42% <50.00%> (ø)
pool.go 72.50% <100.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da966a...5675347. Read the comment docs.

Copy link
Contributor

@dengliming dengliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@filipecosta90
Copy link
Collaborator

@damikem LGTM but we need to add a new method instead of changing the old one so that we're retrocompatible. Can we add a NewClientWithOptions ? Glad to help if required :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants