-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dial options #27
base: master
Are you sure you want to change the base?
Conversation
…tions such as read/write/connect timeout, keep alive and more)
…tions such as read/write/connect timeout, keep alive and more)
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 86.84% 86.89% +0.04%
==========================================
Files 2 2
Lines 266 267 +1
==========================================
+ Hits 231 232 +1
Misses 20 20
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@damikem LGTM but we need to add a new method instead of changing the old one so that we're retrocompatible. Can we add a |
add options for dial when connecting to Redis (allowing to control options such as read/write/connect timeout, keep alive and more)