Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for T-Digest sketch to the client #37

Merged
merged 6 commits into from
Jun 8, 2021
Merged

Add support for T-Digest sketch to the client #37

merged 6 commits into from
Jun 8, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 3, 2021 •
edited
Loading

Codecov Report

Merging #37 (180f2cb) into master (65c8c3a) will increase coverage by 0.65%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   86.84%   87.50%   +0.65%     
==========================================
  Files           2        2              
  Lines         266      328      +62     
==========================================
+ Hits          231      287      +56     
- Misses         20       23       +3     
- Partials       15       18       +3
Impacted Files Coverage Δ
client.go 89.61% <90.32%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c8c3a...180f2cb. Read the comment docs.

hound[bot]
hound bot reviewed Jun 4, 2021
View reviewed changes
client.go Show resolved Hide resolved
@AvitalFineRedis AvitalFineRedis marked this pull request as ready for review June 4, 2021 13:43
@filipecosta90 filipecosta90 changed the title add TDigest function to the client Add support for T-Digest sketch to the client Jun 4, 2021
filipecosta90
filipecosta90 requested changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LVGTM, we just need to address some comments on the function signatures and on the TDIGEST.ADD inputs.

client.go Outdated Show resolved Hide resolved
client.go Show resolved Hide resolved
client.go Show resolved Hide resolved
client.go Show resolved Hide resolved
client.go Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AvitalFineRedis AvitalFineRedis linked an issue Jun 6, 2021 that may be closed by this pull request
Support for T-Digest data structure #31
Closed
@filipecosta90 filipecosta90 added the enhancement New feature or request label Jun 7, 2021
@filipecosta90 filipecosta90 self-requested a review June 7, 2021 12:41
@filipecosta90
Copy link
Collaborator

LVTGM @AvitalFineRedis 👏 . approving!

@AvitalFineRedis AvitalFineRedis merged commit 41854dc into master Jun 8, 2021
@AvitalFineRedis AvitalFineRedis deleted the support_TDigest branch June 8, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

@filipecosta90 filipecosta90 filipecosta90 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for T-Digest data structure
2 participants
@AvitalFineRedis @filipecosta90