Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added make fmt and make lint rules #38

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Added make fmt and make lint rules #38

merged 2 commits into from
Jun 10, 2021

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Jun 3, 2021

This PR is a simple one just to make more verbose the make checkfmt caused errors.
Sample previous output:

checkfmt: Go files must be formatted with go fmt.
Makefile:15: recipe for target 'checkfmt' failed
make: *** [checkfmt] Error 1

Sample new output:

checkfmt: Go files must be formatted with go fmt. Please run `make fmt`
Makefile:15: recipe for target 'checkfmt' failed
make: *** [checkfmt] Error 1

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #38 (77b9c7e) into master (41854dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files           2        2           
  Lines         328      328           
=======================================
  Hits          287      287           
  Misses         23       23           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41854dc...77b9c7e. Read the comment docs.

@filipecosta90 filipecosta90 requested a review from chayim June 3, 2021 15:07
@filipecosta90 filipecosta90 added the x:quality Code-Quality related (performance, test, etc. -not directly affecting functionality) label Jun 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chayim chayim merged commit dfef579 into master Jun 10, 2021
@chayim chayim deleted the clearer.gofmt branch June 10, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:quality Code-Quality related (performance, test, etc. -not directly affecting functionality)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants