-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples to T-Digest functions #39
Conversation
e0561cd
to
872a8b6
Compare
872a8b6
to
3e9191b
Compare
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 2 2
Lines 328 328
=======================================
Hits 287 287
Misses 23 23
Partials 18 18 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvitalFineRedis we need to do some tweaks for it to work
If you run:
godoc -http :6060
Notice:
- you will see that the examples don't show up given we need the name to be changed from for example:
ExampleTdCreate
toExampleClient_TdCreate
given the functions are for the client struct. - another thing is that we mixed 3 examples in one ( min, max, tdcdf ) I would split them into separate ones given we want them to be showcased on each method.
- Notice that
TdCdf()
example should be improved given we use it to calculate cumulative distributions ( so a cumulative dist of 0 is for sure the min... ). Let's target something in the middle. - we also need an example for
TdQuantile()
.
28f2408
to
7a967b8
Compare
7a967b8
to
c167917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo on the comment. apart from it we're good to go. LVGTM
Co-authored-by: filipe oliveira <filipecosta.90@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGTM @AvitalFineRedis
No description provided.