Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for latest TDigest [RedisBloom 2.4.x] #48

Merged
merged 5 commits into from
Nov 10, 2022
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 7, 2022

  • TDigest changes for Bloom 2.4
  • GitHub Actions, and cleanup

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 89.77% // Head: 86.05% // Decreases project coverage by -3.72% ⚠️

Coverage data is based on head (fe4f631) compared to base (bdbc096).
Patch coverage: 63.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   89.77%   86.05%   -3.73%     
==========================================
  Files           2        2              
  Lines         401      423      +22     
==========================================
+ Hits          360      364       +4     
- Misses         23       38      +15     
- Partials       18       21       +3     
Impacted Files Coverage Δ
client.go 87.26% <63.63%> (-4.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.3% 2.3% Duplication

Copy link
Collaborator

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chayim chayim merged commit c298774 into master Nov 10, 2022
@chayim chayim deleted the ck-bloomfixies branch November 10, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants