Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for graph.RO_QUERY command #105

Merged
merged 13 commits into from
Apr 21, 2021

Conversation

filipecosta90
Copy link
Contributor

This PR kicks off the support for graph.RO_QUERY command by introducing queryReadOnly(). It includes the same api methods that query() offers.

Copy link
Contributor

@DvirDukhan DvirDukhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipecosta90

  1. see comments
  2. please add the RO API also to the transactions
  3. I think that we need dedicated test functions for RO API instead of mixing with the current tests, which are messy

src/main/java/com/redislabs/redisgraph/RedisGraph.java Outdated Show resolved Hide resolved
src/main/java/com/redislabs/redisgraph/RedisGraph.java Outdated Show resolved Hide resolved
src/main/java/com/redislabs/redisgraph/RedisGraph.java Outdated Show resolved Hide resolved
src/main/java/com/redislabs/redisgraph/RedisGraph.java Outdated Show resolved Hide resolved
src/main/java/com/redislabs/redisgraph/RedisGraph.java Outdated Show resolved Hide resolved
@tanvirp
Copy link

tanvirp commented Apr 8, 2021

Will RO api work with read only slaves? Looks like

ResultSet resultSet = redisGraph.callProcedure(graphId, procedure);
will eventually call , which will issue the QUERY command instead of RO_QUERY command. I am not sure if this will be taken care in this PR.

@gkorland gkorland requested a review from sazzad16 April 11, 2021 10:27
@gkorland gkorland linked an issue Apr 21, 2021 that may be closed by this pull request
@sazzad16 sazzad16 requested a review from gkorland April 21, 2021 11:36
@sazzad16
Copy link
Collaborator

@tanvirp Do you have a solution in mind? Feel free to craft a PR.

@gkorland gkorland requested review from DvirDukhan and removed request for DvirDukhan April 21, 2021 14:09
@gkorland gkorland merged commit 12ed23f into RedisGraph:master Apr 21, 2021
@filipecosta90 filipecosta90 deleted the graph.ro_query branch April 21, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph.RO_QUERY support
5 participants