Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix character handling in params #84

Merged
merged 3 commits into from
Oct 18, 2020
Merged

fix character handling in params #84

merged 3 commits into from
Oct 18, 2020

Conversation

DvirDukhan
Copy link
Contributor

No description provided.

@gkorland
Copy link
Contributor

@DvirDukhan which scenario does it fix? can you add a test?

@DvirDukhan
Copy link
Contributor Author

@gkorland
I found it by accident when debugged something.
Added test

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #84 into master will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
+ Coverage     78.67%   78.92%   +0.25%     
- Complexity      187      188       +1     
============================================
  Files            23       23              
  Lines           558      560       +2     
  Branches         61       62       +1     
============================================
+ Hits            439      442       +3     
+ Misses           93       92       -1     
  Partials         26       26              
Impacted Files Coverage Δ Complexity Δ
...main/java/com/redislabs/redisgraph/impl/Utils.java 93.75% <100.00%> (+0.20%) 20.00 <0.00> (+1.00)
...abs/redisgraph/impl/api/RedisGraphTransaction.java 79.16% <0.00%> (+4.16%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf34bb...700162e. Read the comment docs.

@gkorland gkorland merged commit dda3619 into master Oct 18, 2020
@gkorland gkorland deleted the fix_char_param_process branch October 18, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants