added 1.99.7 reply format #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilly22
suggested changes
Jan 19, 2020
client_test.go
Outdated
| if err != nil { | ||
| t.Error(err) | ||
| } | ||
| assert.Equal(t, 0, res.IndicesCreated(), "Expecting 1 index deleted") |
query_result.go
Outdated
| @@ -17,6 +17,8 @@ const ( | |||
| RELATIONSHIPS_DELETED string = "Relationships deleted" | |||
| PROPERTIES_SET string = "Properties set" | |||
| RELATIONSHIPS_CREATED string = "Relationships created" | |||
| INDICES_CREATED string = "Indices created" | |||
| INDICES_DELETED string = "Indices deleted" | |||
There was a problem hiding this comment.
looks ok at my machine. re-tabbed
Comment on lines
+356
to
+363
| func (qr *QueryResult) IndicesCreated() int { | ||
| return qr.getStat(INDICES_CREATED) | ||
| } | ||
|
|
||
| func (qr *QueryResult) IndicesDeleted() int { | ||
| return qr.getStat(INDICES_DELETED) | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this really all there's to it?
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 71.63% 71.86% +0.23%
==========================================
Files 7 7
Lines 483 487 +4
==========================================
+ Hits 346 350 +4
Misses 124 124
Partials 13 13
Continue to review full report at Codecov.
|
swilly22
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.