Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read only query support. #46

Merged
merged 5 commits into from
May 24, 2021
Merged

Add read only query support. #46

merged 5 commits into from
May 24, 2021

Conversation

mikewilson-dd
Copy link
Contributor

Just quickly adding in support for the QUERY_RO command.

@mikewilson-dd
Copy link
Contributor Author

@filipecosta90 Hey, sorry to ping you directly -- not sure how active this repo is, but I could really use this feature and it's pretty simple.

@filipecosta90 filipecosta90 added the enhancement New feature or request label May 20, 2021
@filipecosta90
Copy link
Contributor

@filipecosta90 Hey, sorry to ping you directly -- not sure how active this repo is, but I could really use this feature and it's pretty simple.

Hi there @mikewilson-dd , thank you for submitting the PR and pushing it forward. LVGTM. Asking @swilly22 or @jeffreylovitz for an expert opinion on graph :)

swilly22
swilly22 suggested changes May 21, 2021
View reviewed changes
graph.go Outdated Show resolved Hide resolved
mikewilson-dd
mikewilson-dd commented May 24, 2021
View reviewed changes
graph.go Outdated Show resolved Hide resolved
@filipecosta90
Copy link
Contributor

@mikewilson-dd after discussing the naming with @swilly22 we've agreed that is best to keep the language standards and go with your suggestion of RoQuery, making the following func (g *Graph) ROQuery(q string) (*QueryResult, error) signature.
I've reverted that specific change from the latest commit and we're good to go 👍
Thank you for pushing this forward!

@filipecosta90 filipecosta90 merged commit ddcecfd into RedisGraph:master May 24, 2021
@mikewilson-dd
Copy link
Contributor Author

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilly22 swilly22 swilly22 requested changes

@filipecosta90 filipecosta90 filipecosta90 approved these changes

@jeffreylovitz jeffreylovitz Awaiting requested review from jeffreylovitz

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikewilson-dd @filipecosta90 @swilly22