Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a quick start guide for generic K8s #1007

Merged
merged 6 commits into from
Jan 6, 2021
Merged

Added a quick start guide for generic K8s #1007

merged 6 commits into from
Jan 6, 2021

Conversation

alexmilowski
Copy link
Contributor

A simple quick start guide.

@alexmilowski alexmilowski requested a review from amiramm September 2, 2020 22:12
@bmansheim bmansheim added the enhancement Additional information or functionality label Sep 3, 2020
amiramm
amiramm requested changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@amiramm amiramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. see comments.

content/platforms/kubernetes/quick-start.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/quick-start.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/quick-start.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/quick-start.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/quick-start.md Outdated Show resolved Hide resolved
@bmansheim
Copy link
Contributor

@alexmilowski Do you want to respond to the comments?

amiramm
amiramm requested changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@amiramm amiramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment. Plz consider ending with a connection to the database (for example, with crdb-cli)

content/platforms/kubernetes/getting-started/quick-start.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/getting-started/quick-start.md Outdated Show resolved Hide resolved
@alexmilowski
Copy link
Contributor Author

This now works with the K8s reorg and I've updated it to address the comments.

@amiramm amiramm self-requested a review January 5, 2021 23:33
amiramm
amiramm approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@amiramm amiramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmansheim bmansheim changed the base branch from master to DOC-441-quick-start-guide-k8s January 6, 2021 13:01
@bmansheim bmansheim merged commit df8c2f6 into RedisLabs:DOC-441-quick-start-guide-k8s Jan 6, 2021
@bmansheim
Copy link
Contributor

Merged to #1174 for style review

banker pushed a commit that referenced this pull request Feb 1, 2021
@bmansheim @alexmilowski
DOC-441 Added a quick start guide for generic K8s (#1174)
bc795c3 
* Added a quick start guide for generic K8s (#1007)

Co-authored-by: Alex Milowski <alex@milowski.com>
Co-authored-by: Kyle Banker <kyle.banker@redislabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiramm amiramm amiramm approved these changes

Assignees
No one assigned
Labels
enhancement Additional information or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexmilowski @bmansheim @amiramm