-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rladmin reference (Doc-83, DOC-210, DOC-606) #1256
Conversation
@kaitlynmichaelredislabs - While I review this, how are we planning on keeping this up-to-date? |
@AlonMagrafta we want any public documentation to always be up-to-date. I already know this page is missing |
Please try to find time to review this PR this week; I am aiming to merge this on Friday 3/12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting this! I've made some comments, mostly around how we approach this type of document - you may have already discussed this offline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of lines 1-300
`rladmin cluster config` updates the cluster configuration. | ||
|
||
```text | ||
rladmin cluster config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual order is different + few new ones (16,18,19):
- cipher_suites
- cm_port
- cm_session_timeout_minutes
- cnm_http_port
- cnm_https_port
- data_cipher_list
- debuginfo_path
- handle_redirects
- http_support
- ipv6
- min_control_TLS_version
- min_data_TLS_version
- min_sentinel_TLS_version
- s3_url
- saslauthd_ldap_conf
- sentinel_cipher_suites
- sentinel_ssl_policy
- services
- upgrade_mode <enabled/disabled> (Alon: I must say I'm not sure yet what that is)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlonMagrafta Do you have the arguments and descriptions for sentinel_cipher_suites
, services
, upgrade_mode
?
rladmin cluster services [ cm_server | crdb_coordinator | crdb_worker | mdns_server | pdns_server | saslauthd | stats_archiver <enabled | disabled> ] | ||
``` | ||
|
||
### `failover` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlonMagrafta : Mark to myself, I reviewed this PR to this point, not including the extended part of cluster create+recover+join
Co-authored-by: Amiram Mizne <amiramm@users.noreply.github.com>
Co-authored-by: Alon Magrafta <50071256+AlonMagrafta@users.noreply.github.com>
Co-authored-by: Alon Magrafta <50071256+AlonMagrafta@users.noreply.github.com>
No description provided.