Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc 781 Manage REC credentials procedure #1466

Merged
merged 19 commits into from
Jul 29, 2021
Merged

Doc 781 Manage REC credentials procedure #1466

merged 19 commits into from
Jul 29, 2021

Conversation

kaitlynmichael
Copy link
Contributor

Composed based off document from R&D attached to DOC-781

@kaitlynmichael kaitlynmichael added the K8s Kubernetes label Jul 27, 2021
@kaitlynmichael kaitlynmichael self-assigned this Jul 27, 2021
@kaitlynmichael
Copy link
Contributor Author

Staging site: https://docs.redislabs.com/staging/DOC-781/platforms/kubernetes/concepts/manage_rec_credentials/

lanceleonard
lanceleonard approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@lanceleonard lanceleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Suggestions are recommendations. (Also, should we add pods to the glossary with a link to the K8s article? Or just link the existing use of "Pods" to the K8s article?)

content/platforms/kubernetes/concepts/manage_REC_credentials.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/concepts/manage_REC_credentials.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/concepts/manage_REC_credentials.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/concepts/manage_REC_credentials.md Outdated Show resolved Hide resolved
rrelledge
rrelledge approved these changes Jul 28, 2021
View reviewed changes
Copy link
Collaborator

@rrelledge rrelledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just left a couple of small suggestions in the comments.

content/platforms/kubernetes/concepts/manage_REC_credentials.md Outdated Show resolved Hide resolved
content/platforms/kubernetes/concepts/manage_REC_credentials.md Outdated Show resolved Hide resolved
@kaitlynmichael @rrelledge @lanceleonard
Apply suggestions from code review
30d3f79 
Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>
Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>
@kaitlynmichael kaitlynmichael merged commit 0f3d77d into master Jul 29, 2021
@kaitlynmichael kaitlynmichael deleted the DOC-781 branch July 29, 2021 20:19
rrelledge added a commit that referenced this pull request Aug 17, 2021
@rrelledge @IAmATeaPot418
@AlonMagrafta @kaitlynmichael @lanceleonard @vikrammoule-redislabs @gilbennun
Merge master back into release-ri-v2.0 (#1493)
f713c55 
* Small fix (#1468)

back from the dead - also this is ugly. Miss you guys.

* can add module only on creation (#1469)

* can add module only on creation

* Update add-module-to-database.md

* Cleaned up RS clients index page and added an auto-generating table shortcode (#1467)

* Doc 781 Manage REC credentials procedure (#1466)

* Jira DOC-760: RC - Finish reorganizing Concepts content. (#1454)

* Initial draft/implementation

* Updating glossary link

* Adding new section to entry page.

* Initial pass to reorg/clean-up Cloud account docs.

* Typos and other editorial fixes

* Updating flush-all article/mini-toc min word count.

* Edits to cloud account entry page

* Moving remaining how-to articles to admin sections

* RS: Removed v5.2 from version dropdown (#1470)

* Add dynatrace issue RED-54704 to upgrade notes (#1464)

Dynatrace agent installed on the cluster nodes can hamper the working on Envoy process leading to failure of UI and REST API. Prior upgrading we recommed removing Dynatrace completely or try upgrading to newer versions.

* Updated info on REC password and editorial changes (#1471)

* Initial draft (#1472)

* Update give Cloud access to a GCP user (#1087)

* Update account-team-settings.md

* Update content/rc/administration/account-team-settings.md

* Update content/rc/administration/account-team-settings.md

* Update content/rc/administration/account-team-settings.md

* Update content/rc/administration/account-team-settings.md

Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>

* Changelog:  July 2021 updates (#1473)

* Initial draft

* Typo fix

* Update changelog.md

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Updating admin password on Clusters with CRDB (#1474)

* Updating admin password on Clusters with CRDB

* Update content/rs/security/admin-console-security/user-security.md

Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>

* Update content/rs/security/admin-console-security/user-security.md

Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>

* Update content/rs/security/admin-console-security/user-security.md

Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>

* Update content/rs/security/admin-console-security/user-security.md

Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>

* Update content/rs/security/admin-console-security/user-security.md

Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>

* Update content/rs/security/admin-console-security/user-security.md

Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>

* Update content/rs/security/admin-console-security/user-security.md

Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>

* Update content/rs/security/admin-console-security/user-security.md

Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>

* Update content/rs/security/admin-console-security/user-security.md

Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>

Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>

* Fixing merge issues

* Active Active expiration values (#1475)

* Active Active expiration values

* Update content/rs/references/developing-for-active-active/_index.md

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Added non-breaking spaces to expiration ranges

Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>

* Squashed commit of the following updates 

commit e26f2e90 
Author: Lance Leonard <lanceleonard@users.noreply.github.com> 
Date: Tue Aug 10 2021 09:37:51 GMT-0500 (Central Daylight Time) 

    Ugh.  Tpyo


commit 322e1820 
Author: Lance Leonard <lanceleonard@users.noreply.github.com> 
Date: Mon Aug 09 2021 22:52:07 GMT-0500 (Central Daylight Time) 

    More updates


commit d589f766 
Author: Lance Leonard <lanceleonard@users.noreply.github.com> 
Date: Mon Aug 09 2021 11:41:30 GMT-0500 (Central Daylight Time) 

    Initial draft of changes


commit 46ba9c7a 
Author: Lance Leonard <lanceleonard@users.noreply.github.com> 
Date: Fri Aug 06 2021 14:19:43 GMT-0500 (Central Daylight Time) 

    Merge branch 'master' into content-updates to bring up-to-date with other project (though Fri Aug 6)


commit 0e20399b 
Author: Rachel Elledge <rachel.elledge@redislabs.com> 
Date: Fri Aug 06 2021 10:38:21 GMT-0500 (Central Daylight Time) 

    Updated terraform IAM template json


commit 5feb8d43 
Author: Rachel Elledge <rachel.elledge@redislabs.com> 
Date: Fri Aug 06 2021 10:23:00 GMT-0500 (Central Daylight Time) 

    Updated circleci jobs


commit 2a79ccb4 
Author: Rachel Elledge <rachel.elledge@redislabs.com> 
Date: Tue Aug 03 2021 14:32:43 GMT-0500 (Central Daylight Time) 

    Updated contribution and editing guides


commit a5a66a71 
Author: Rachel Elledge <rachel.elledge@redislabs.com> 
Date: Tue Aug 03 2021 14:30:22 GMT-0500 (Central Daylight Time) 

    Updated site title


commit 89cfb28c 
Author: Rachel Elledge <rachel.elledge@redislabs.com> 
Date: Tue Jul 27 2021 17:13:57 GMT-0500 (Central Daylight Time) 

    updated footer


commit 94ae7731 
Author: Rachel Elledge <rachel.elledge@redislabs.com> 
Date: Tue Jul 27 2021 17:12:44 GMT-0500 (Central Daylight Time) 

    logo


commit c8d1f0c2 
Author: Rachel Elledge <rachel.elledge@redislabs.com> 
Date: Tue Jul 27 2021 16:34:56 GMT-0500 (Central Daylight Time) 

    README and LICENSE updates

* Squashed commit of the following web updates

commit 9b11ae0b 
Author: Rachel Elledge <rachel.elledge@redislabs.com> 
Date: Tue Aug 10 2021 10:48:09 GMT-0500 (Central Daylight Time) 

    Updated website.json


commit 3ace752e 
Author: Rachel Elledge <rachel.elledge@redislabs.com> 
Date: Mon Aug 09 2021 09:08:58 GMT-0500 (Central Daylight Time) 

    Updated robots.txt

* A couple more updates

* Updated search site url

* Updated CircleCI jobs

* Logo (#1480)

* Updated CircleCI jobs

* Fixing CircleCI config bug

* Fixing table layout.  (Maybe?) (#1482)

* Fixing table layout.  (Maybe?)

* Adding missing newline

* Adjusting z-index to fix icon overlap issues

* Adding redirect. (#1484)

* Updating css test (#1483)

* Fixing table layout.  (Maybe?)

* Adding missing newline

* Adjusting z-index to fix icon overlap issues

* Updating test rule

* Css fix test (#1485)

* Fixing table layout.  (Maybe?)

* Adding missing newline

* Adjusting z-index to fix icon overlap issues

* Updating test rule

* Varying the test

* Doc 851 log-collector script instructions (#1486)

* Fixed incorrect GTM container and deduped the GA scripts (#1487)

* Fixed incorrect GTM ID and deduped GA scripts

* Added purge site cache step to CircleCI deploy jobs (#1488)

* [Urgent] 6.0.20 known limitation - 2 critical bugs (#1492)

* [Urgent] 6.0.20 known limitation - 2 critical bugs

* Update rs-6-0-20-april-2021.md

Co-authored-by: Jamie Scott <jamie.scott@uconn.edu>
Co-authored-by: Alon Magrafta <50071256+AlonMagrafta@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>
Co-authored-by: vikrammoule-redislabs <39086205+vikrammoule-redislabs@users.noreply.github.com>
Co-authored-by: gilbennun <39088155+gilbennun@users.noreply.github.com>
rrelledge pushed a commit that referenced this pull request Aug 17, 2021
@kaitlynmichael @rrelledge
Doc 781 Manage REC credentials procedure (#1466)
7cc10bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvallevy2 yuvallevy2 yuvallevy2 left review comments

@lanceleonard lanceleonard lanceleonard approved these changes

@rrelledge rrelledge rrelledge approved these changes

@amiramm amiramm Awaiting requested review from amiramm

@laurentdroin laurentdroin Awaiting requested review from laurentdroin

Assignees

@kaitlynmichael kaitlynmichael

Labels
K8s Kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaitlynmichael @lanceleonard @yuvallevy2 @rrelledge