Changes from feature-search-json branch #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring (#136) * WIP * WIP (export rejson api and expose key_inner) * WIP (commit before rolling-back to bisect/detect a crash) * WIP open key using RedisModuleString * WIP fix borrow of RedisKeyWritable::get_value * WIP cleanup remove unnecessary code * WIP cleanup Co-authored-by: oshadmi <omer.shadmi@redislabs.com>
WIP open_with_redis_string does not take ownership of the RedisModuleString
[feature-search-json] Merge from master
gkorland
suggested changes
Apr 26, 2021
src/key.rs
Outdated
| key_str, | ||
| ctx: ctx, | ||
| key_inner: key_inner, | ||
| key_str: Some(key_str), |
There was a problem hiding this comment.
@oshadmi can we remove key_str?
There was a problem hiding this comment.
Yes, we can remove it.
gkorland
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.