Add support for unlink #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshadmi
reviewed
Sep 6, 2022
| /// | ||
| /// Will panic if `RedisModule_UnlinkKey` is missing in redismodule.h | ||
| pub fn unlink(&self) -> RedisResult { | ||
| unsafe { raw::RedisModule_UnlinkKey.unwrap()(self.key_inner) }; |
There was a problem hiding this comment.
On success REDISMODULE_OK is returned. If the key is not open for writing REDISMODULE_ERR is returned.
Consider returning the actual result
There was a problem hiding this comment.
Yes, thought about it, but for consistency I just copied the same API of delete
There was a problem hiding this comment.
If we would like to fix both, when can we do such a breaking change in this module?
Since it may affect other consumers and not only RedisJSON, a config/feature-flag may help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.