Added API to register to server events. #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MeirShpilraien do you need to break the crate to two crates? |
|
@gkorland Yes, derives and proc macros must be on a separate trait. This is why you have serde and serde_derive for example. |
gkorland
suggested changes
Jan 26, 2023
Co-authored-by: Guy Korland <gkorland@gmail.com>
MeirShpilraien
force-pushed
the
server_events_api
branch
from
28181a1
to
037c8db
Compare
chayim
reviewed
Feb 1, 2023
| @@ -27,8 +27,23 @@ jobs: | |||
| file: "Cargo.toml" | |||
| key: "package.version" | |||
| value: "${{ steps.get_version.outputs.VERSION }}" | |||
|
|
|||
| - name: Set the version for publishing on derive crate | |||
There was a problem hiding this comment.
Probably need to also edit redismodule-rs-derive?
There was a problem hiding this comment.
This one is editing redismodule-rs-derive
iddm
previously approved these changes
Mar 13, 2023
Open
oshadmi
reviewed
Mar 19, 2023
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
iddm
previously approved these changes
Mar 21, 2023
iddm
previously approved these changes
Mar 21, 2023
iddm
previously approved these changes
Mar 21, 2023
iddm
approved these changes
Mar 21, 2023
gkorland
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR also introduce a new crate, redismodule-rs-derive, which is use to implement derive and proc macro functionality. Server events are registered using a
proc_macro_attributethat add the server event handler to the relevant list server events handler list. This binding is done using: https://github.com/dtolnay/linkme