-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update redocly.yaml validation #1259
Conversation
🦋 Changeset detectedLatest commit: 26c4e6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success625 tests passing in 91 suites. Report generated by 🧪jest coverage report action from 26c4e6b |
c5744f6
to
26c4e6b
Compare
Are we asking docs in this pull request, or capturing in an issue what we need to add later? Link the issue if its separate |
@lornajane I don't think there's something to be documented here. We are only catching up with the Portal config, no changes to the CLI config itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also will be great to see some e2e test for validation of config.
At least for cases with metadata-schema
and custom-fields-schema
Got it. I thought we were also adopting the rules and would need docs. Now I see it's just the validation |
@SmoliyY I see your point, but those don't make sense in the CLI itself as they are not quite rules and are only related to the Portal. |
What/Why/How?
Redocly config validation update.
Copied and pasted validation schemas from the Portal, and added additional 'rules' validation (
metadata-schema
andcustom-fields-schema
).Reference
Testing
Tested on Portal playground's and Rebilly redocly.yaml files.
Screenshots (optional)
Check yourself
Security