Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed parameters-not-in-body rule #1832

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

DmitryAnansky
Copy link
Contributor

@DmitryAnansky DmitryAnansky commented Dec 18, 2024

What/Why/How?

  • Removed parameters-not-in-body rule as we plan to support this in Spot.
  • Renamed rule version-enum to spot-supported-versions.
  • Changed severity for Spot related rules to off. Spot validation limitations should not affect the Arazzo standard validation ruleset.

Reference

Part of: https://github.com/Redocly/redocly/issues/11339

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 988.3 ± 47.3 943.9 1081.3 1.01 ± 0.05
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 977.3 ± 14.9 961.4 1012.0 1.00

@DmitryAnansky DmitryAnansky force-pushed the feat/remove-parameters-not-in-body-rule branch from 1c19763 to 08a1eab Compare December 18, 2024 16:50
Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: b56de1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.6% 5043/6416
🟡 Branches 67.21% 2052/3053
🟡 Functions 73.11% 832/1138
🟡 Lines 78.89% 4757/6030
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / spot-supported-versions.ts
100% 100% 100% 100%

Test suite run success

832 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from b56de1a

@DmitryAnansky DmitryAnansky changed the title feat: remove parameters-not-in-body rule feat: removed parameters-not-in-body rule Dec 18, 2024
@DmitryAnansky DmitryAnansky marked this pull request as ready for review December 18, 2024 17:08
@DmitryAnansky DmitryAnansky requested review from a team as code owners December 18, 2024 17:08
@DmitryAnansky DmitryAnansky reopened this Dec 18, 2024
@DmitryAnansky DmitryAnansky merged commit 54bc377 into main Dec 19, 2024
41 checks passed
@DmitryAnansky DmitryAnansky deleted the feat/remove-parameters-not-in-body-rule branch December 19, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants