write a new file on first run, and fix routes

ReeceM · May 5, 2019 · 29dbe7a · 29dbe7a
1 parent 9c6916f
commit 29dbe7a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/routes/web.php b/routes/web.php
@@ -4,5 +4,5 @@
  */
 use Illuminate\Support\Facades\Route;
 
-Route::get(config('setting.path') . '/settings/refresh',	'SettingController@refresh')->name('refresh');
-Route::resource(config('setting.path') . '/settings', 		'SettingController');
+Route::get('/settings/refresh',	'SettingController@refresh')->name('settings.refresh');
+Route::resource('/settings', 		'SettingController');
diff --git a/src/Services/SettingService.php b/src/Services/SettingService.php
@@ -72,6 +72,7 @@ public function cache()
         $this->files->put(
             $configPath, '<?php return '.var_export($this->settings, true).';'.PHP_EOL
         );
+        return true;
     }
     /**
      * Reads the settings file into memory
@@ -81,8 +82,12 @@ public function load()
         try {
             $this->settings = $this->files->getRequire(base_path('bootstrap/cache/' . static::$configName));
         } catch (\Exception $e) {
-            Log::critical('Failed to load system settings with error: ' . $e);
-            throw $e;
+
+            if(! $this->cache()) {
+                Log::critical('Failed to load system settings with error: ' . $e);
+                session()->flash('setting.flash.danger', 'Failed to load system settings file from storage');
+            }
+            // throw $e;
         }
     }
     /**