-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forgotten API_SUFFIX wrappers to LAPACKE_?TFSM and fix the MacOS CI jobs #1057
Add forgotten API_SUFFIX wrappers to LAPACKE_?TFSM and fix the MacOS CI jobs #1057
Conversation
The merge-base changed after approval.
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me and the CI is happy.
The merge-base changed after approval.
(and obviously it is not me dismissing your reviews, but github hiccuping due to that "partial" merge) |
Let us revert my previous merge #1046. And start clean. |
Idk, the two PRs are technically unrelated (which is why I had them separate originally) and this here is exactly identical content-wise. So IMHO reverting just to get this one in would be messier ? |
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
You were right about the mess. We ended up merging #1045 and #1046, so we can close this one without merge. Sorry for the trouble! |
Description
The missing API_SUFFIX wrappers appear to be an oversight from the recent #1042
This version of the PR combines my previous #1046 with my unrelated PR #1045 to
fix the CI jobs that got broken by the removal of gcc-11 from the underlying image
(as requested by @weslleyspereira)