Refactor speakers/registration schemas and db #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobc2700
force-pushed
the
dev/jacob/speakers-refactor
branch
7 times, most recently
from
d082bf2
to
aa98282
Compare
jacobc2700
force-pushed
the
dev/jacob/speakers-refactor
branch
from
aa98282
to
4085789
Compare
AydanPirani
requested changes
Aug 13, 2024
|
|
||
| // Zod schema for speaker | ||
| export const SpeakerValidator = z.object({ | ||
| speakerId: z.coerce.string().default(() => uuidv4()), |
| import { v4 as uuidv4 } from "uuid"; | ||
|
|
||
| // Zod schema for speaker | ||
| export const SpeakerValidator = z.object({ | ||
| speakerId: z.coerce.string().default(() => uuidv4()), |
There was a problem hiding this comment.
this shouldnt be needed - also make changes to speaker, so that we have the following:
GET /speakers/:SPEAKERID
PUT /speakers/:SPEAKERID
POST /speakers/ (create speakerid)
There was a problem hiding this comment.
I think those endpoints were added already ?
|
@jacobc2700 bumping this up! |
AydanPirani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor speakers service