Add flexibility to s3 #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AydanPirani
reviewed
Jul 16, 2024
AydanPirani
reviewed
Aug 27, 2024
divyack2
requested changes
Aug 27, 2024
src/services/s3/s3-utils.ts
Outdated
| import { getSignedUrl } from "@aws-sdk/s3-request-presigner"; | ||
| import { createPresignedPost } from "@aws-sdk/s3-presigned-post"; | ||
|
|
||
| export async function postResumeUrl(userId: string, client: S3) { | ||
| export async function postResumeUrl( |
There was a problem hiding this comment.
nit: rename the get and post function names because now these functions will be getting URLs for both resumes and for speaker images
There was a problem hiding this comment.
so it's no longer just getResumeURL/postResumeURL
|
hello! @jacobc2700 bumping this back up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change/PR 1: add flexibility to s3
make changes to config.ts with a new native enum (non-zod) for bucket names.
enum names should be all caps, bucket names should not
in the enum, add current resume bucket rp-2024-resumes, but also add one for speakers (rp-2024-speakers)
pass that enum as a parameter into the get/postUrl methods in s3-utils.ts
use that enum's value to get the actual bucket name, instead of the config/env value (you can delete the current hardcoded bucket from config)