Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference to docker troubleshooting wiki in CONTRIBUTING.md #625

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Add reference to docker troubleshooting wiki in CONTRIBUTING.md #625

merged 2 commits into from
Jun 23, 2020

Conversation

piercebb
Copy link
Contributor

Context

Summary of Changes

  • Added link to docker troubleshooting wiki in CONTRIBUTING.md

Checklist

  • Tested Mobile Responsiveness
  • Added Unit Tests
  • CI Passes
  • Deploys to Heroku on test Correctly (Maintainers will handle)
  • Added Documentation (Service and Code when required)

Screenshots

Before

Screen Shot 2020-06-23 at 1 10 38 PM

After

Screen Shot 2020-06-23 at 1 10 22 PM

DeeDeeG
DeeDeeG approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! I will take a look at the other issues and PRs next.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jun 23, 2020

This makes plenty of sense to be in CONTRIBUTING.md and I think the text is good, too. Thanks again!

@DeeDeeG DeeDeeG merged commit d5fee11 into RefugeRestrooms:develop Jun 23, 2020
@DeeDeeG DeeDeeG mentioned this pull request Jul 7, 2020
Merged
DeeDeeG added a commit that referenced this pull request Jul 8, 2020
@DeeDeeG @piercebb
Release 1.19.2 (#630)
6f80471 
* Add reference to docker troubleshooting wiki in `CONTRIBUTING.md` (#625)

  - Add reference to docker troubleshooting wiki in contributing documentation

  - Update CONTRIBUTING.md

* Add listeners to close infowindow when another is opened (#628)

* CONTRIBUTING.md: Docker for Windows requirements

-  Docker Desktop for Window requires Windows 10 64-bit,
   "Professional" or "Enterprise" editions.

* Update dependencies June 2020 (#629)

  - dependencies: Bump geocoder, websocket-extensions

  - Gemfile.lock: Update rack to 2.2.3

Co-authored-by: Pierce Bala <65255475+piercebb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeeDeeG DeeDeeG DeeDeeG approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piercebb @DeeDeeG