Add new sensor "Preclimate Status" for hybrid and electric vehicles #264
Conversation
|
I'm not completely thrilled with the name "Preclimate Status." I went with it for consistency, but I would prefer to stick to the official attribute names. |
philippwaller
changed the title
|
Thanks for this good PR! Unfortunately, precondOperqtingMode is not a good sensor core value. This is reported for EQE, B and S but not for hybrids and EQV and some others like smarts. Means that all these would be not available for these car types. We can calculate the active value based on active/now. |
…precond_status_handler - Refactored _get_car_values to use the handler pattern, improving readability and scalability. - Added precond_status_handler to calculate the precondition status based on precondNow, precondActive and precondOperatingMode.
|
Thank you very much for your feedback and the valuable insights! I've implemented your suggestions right away and additionally integrated precondOperatingMode into the calculation, as my tests have shown that this value is updated a bit earlier than the other two. I took the opportunity to modularize the _get_car_values function in the spirit of "opportunistic refactoring" 🚀. |
|
Thanks, let me check this. OperatingMode possible values: So your >0 = Active assumption is right. |
|
merged, thanks - I will add a few cleanups and the translation |
This pull request introduces a new sensor called "Preclimate Status" to provide insights into the current status of the preconditioning system for hybrid and electric vehicles. Additional attributes providing further details about the preconditioning states, such as duration, trigger, configured departure time, selected seats and more.
For reference, this PR addresses issue #263.