Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align configuration classes with Home Assistant standards #270

Merged
merged 9 commits into from
Oct 13, 2024
Merged

Align configuration classes with Home Assistant standards #270

merged 9 commits into from
Oct 13, 2024

Conversation

philippwaller
Copy link
Contributor

This PR refines the configuration classes to better adhere to Home Assistant's coding standards and best practices.

ReneNulschDE
ReneNulschDE requested changes Oct 12, 2024
View reviewed changes
Copy link
Owner

@ReneNulschDE ReneNulschDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx - could you check the last comments please.

custom_components/mbapi2020/__init__.py Outdated Show resolved Hide resolved
custom_components/mbapi2020/__init__.py Outdated Show resolved Hide resolved
custom_components/mbapi2020/__init__.py Outdated Show resolved Hide resolved
custom_components/mbapi2020/__init__.py Show resolved Hide resolved
custom_components/mbapi2020/switch.py Outdated Show resolved Hide resolved
custom_components/mbapi2020/switch.py Outdated Show resolved Hide resolved
@ReneNulschDE
Copy link
Owner

I will implement the needed changes to get the release out. Thx!

@philippwaller
Copy link
Contributor Author

philippwaller commented Oct 12, 2024 •
edited
Loading

Sorry, I was on a roadtrip. Are you already working on it?

@ReneNulschDE
Copy link
Owner

No problem. I like your contributions and all the needed stuff is fixed. Just have a problem with the not working translation. Need to dive deeper tomorrow. Thanks again!

@philippwaller
Copy link
Contributor Author

It’s strange that the translations aren’t being applied. I tested it on Friday morning and was quite sure that at least the German translations were showing up. I looked into it again last night but couldn’t spot the issue at first glance. 🤔

@ReneNulschDE
Copy link
Owner

OK - the sensor/switch title translation is not working at all. It showed the German value because your HA system language is DE. I will remove the german translation for now to make sure that the entities are created with english naming. I'll merge the PR with a few other changes and then work on the translation bug.

@ReneNulschDE ReneNulschDE merged commit 6750d8f into ReneNulschDE:master Oct 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneNulschDE ReneNulschDE ReneNulschDE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippwaller @ReneNulschDE