-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate Mantle to 0xGraph #101
Conversation
WalkthroughThe changes involve updates to the configuration of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
I deployed the Mantle Payments Subgraph to 0xGraph in commit 1359c4b using the manual deployment instructions listed below:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (3)
- cli/graph-nodes.ts (1 hunks)
- package.json (1 hunks)
- subgraph.mantle.yaml (5 hunks)
Additional comments not posted (8)
cli/graph-nodes.ts (2)
28-28
: Endpoint URL Updated CorrectlyThe change to the
deploy
endpoint URL for themantle
network appears correct and aligns with the new service provider's URL structure. Ensure to verify the availability and functionality of the new endpoint.Run the following script to verify the endpoint's availability:
Verification successful
Endpoint URL Verified Successfully
The
deploy
endpoint URL for themantle
network is reachable and responding with a200
status code, confirming its availability and correctness. No further action is required.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the new deploy endpoint is reachable. curl -o /dev/null -s -w "%{http_code}\n" https://subgraph-api.mantle.xyz/deployLength of output: 85
30-30
: IPFS Endpoint URL Updated CorrectlyThe change to the
ipfs
endpoint URL for themantle
network appears correct and aligns with the new service provider's URL structure. Ensure to verify the functionality of the new IPFS endpoint.Run the following script to verify the IPFS endpoint's functionality:
package.json (2)
15-15
: Deployment Command Updated CorrectlyThe update to the
create-mantle
command in thescripts
section appears correct and aligns with the new service provider's URL structure. Ensure to verify the functionality of the new command.Run the following script to verify the command's functionality:
23-23
: Dependency Version Updated CorrectlyThe update to the
@graphprotocol/graph-cli
dependency version appears correct. Ensure to verify the compatibility of the new version with the project's existing configuration and functionality.Run the following script to verify the dependency's compatibility:
subgraph.mantle.yaml (4)
7-7
: Network Designation Updated CorrectlyThe change to the
network
field for theERC20Proxy
data source appears correct and aligns with the strategic pivot towards utilizing the Mantle network. Ensure to verify the functionality of the new network designation.Run the following script to verify the network's functionality:
Verification successful
Network Designation Verified
The change to the
network
field for theERC20Proxy
data source tomantle
is correct and supported by the codebase. The Mantle network is referenced in multiple configuration and documentation files, indicating it is a recognized and operational network within the project. No further action is required.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the new network designation is functional. yarn deploy-localLength of output: 91
Script:
#!/bin/bash # Search for references to 'mantle' in the codebase to verify its usage and configuration. rg 'mantle' -A 5 # Search for any configuration or setup scripts that might involve the 'mantle' network. ast-grep --lang yaml --pattern 'network: mantle'Length of output: 6422
49-49
: Network Designation Updated CorrectlyThe change to the
network
field for theEthProxy_0_3_0
data source appears correct and aligns with the strategic pivot towards utilizing the Mantle network. Ensure to verify the functionality of the new network designation.Run the following script to verify the network's functionality:
Verification successful
Network Change to Mantle is Well-Integrated
The change to the
network
field for theEthProxy_0_3_0
data source tomantle
is consistent with the project's configuration and documentation. Themantle
network is well-represented across various files, indicating a deliberate and supported integration. Ensure to verify the deployment process in an environment where the necessary tools are available.
- Files with Mantle References:
subgraph.mantle.yaml
package.json
cli/networks.json
README.md
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the new network designation is functional. yarn deploy-localLength of output: 91
Script:
#!/bin/bash # Search for occurrences of 'mantle' in the codebase to find related configurations or documentation. rg 'mantle' -A 5Length of output: 6262
70-70
: Network Designation Updated CorrectlyThe change to the
network
field for theEthFeeProxy_0_2_0
data source appears correct and aligns with the strategic pivot towards utilizing the Mantle network. Ensure to verify the functionality of the new network designation.Run the following script to verify the network's functionality:
Verification successful
Network Designation Updated Correctly
The change to the
network
field for theEthFeeProxy_0_2_0
data source tomantle
is well-supported by the codebase. The Mantle network is comprehensively configured across multiple files, including deployment scripts and network endpoints. Ensure to verify the functionality of the new network designation in a suitable environment.
- Files with Mantle Configuration:
subgraph.mantle.yaml
package.json
cli/networks.json
cli/graph-nodes.ts
README.md
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the new network designation is functional. yarn deploy-localLength of output: 91
Script:
#!/bin/bash # Search for references to the 'mantle' network in the codebase to verify its configuration and usage. rg 'mantle' -A 5Length of output: 6262
28-28
: Network Designation Updated CorrectlyThe change to the
network
field for theERC20FeeProxy_0_2_0
data source appears correct and aligns with the strategic pivot towards utilizing the Mantle network. Ensure to verify the functionality of the new network designation.Run the following script to verify the network's functionality:
Verification successful
Network Designation to Mantle Verified
The change to the
network
field for theERC20FeeProxy_0_2_0
data source tomantle
is correctly configured and integrated within the codebase. The Mantle network is referenced in multiple configuration files, scripts, and documentation, indicating proper setup and usage. No further action is required.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the new network designation is functional. yarn deploy-localLength of output: 91
Script:
#!/bin/bash # Search for references to the 'mantle' network in the codebase to verify its configuration and usage. rg 'mantle' --context 5Length of output: 9467
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
Resolves #90
Please approve as-is because this was the state of the Repo when I deployed. I'll clean up the mantle stuff in a future PR.
Changes
@graphprotocol/graph-cli
to 0.81.0mantle.subgraph.yaml
to usemantle
network namecli/graph-nodes.ts
and thecreate-mantle
script inpackage.json
. These hacks were ultimately unused. Deployed manually instead.Summary by CodeRabbit
New Features
Bug Fixes
These changes aim to optimize the deployment process and enhance user experience in managing subgraphs.