Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set is_active to false when suspending user #1968

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Set is_active to false when suspending user #1968

merged 1 commit into from
Nov 5, 2024

Conversation

koutst
Copy link
Contributor

@koutst koutst commented Nov 5, 2024

@koutst koutst requested a review from a team as a code owner November 5, 2024 20:44
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (136aab3) to head (a3c1bcf).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/user/views/user_views.py 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
- Coverage   64.58%   64.57%   -0.02%     
==========================================
  Files         407      407              
  Lines       23662    23667       +5     
==========================================
  Hits        15282    15282              
- Misses       8380     8385       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gzurowski
gzurowski approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@gzurowski gzurowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@koutst koutst merged commit a7463b5 into master Nov 5, 2024
3 of 5 checks passed
@koutst koutst deleted the use-is-active-to-deactivate branch November 5, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzurowski gzurowski gzurowski approved these changes

@yattias yattias yattias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set is_active when suspending and reinstating users
3 participants
@koutst @yattias @gzurowski