Person suggest #1972
Open
Person suggest #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yattias
force-pushed
the
person-suggest
branch
from
2baaf72
to
e85029a
Compare
|
yattias
commented
Nov 6, 2024
| @@ -8,7 +8,8 @@ | |||
| "program": "${workspaceFolder}/src/manage.py", | |||
| "args": [ | |||
| "runserver", | |||
| "[::]:8000" | |||
| "[::]:8000", | |||
| "--ipv6" | |||
There was a problem hiding this comment.
I'll remove this before merging
yattias
commented
Nov 6, 2024
| @@ -117,6 +117,39 @@ def __str__(self): | |||
| f"{university_city}" | |||
| ) | |||
|
|
|||
| def build_headline(self): | |||
There was a problem hiding this comment.
Move this method from serializer to model so that it can be used by elasticsearch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1972 +/- ##
==========================================
+ Coverage 64.66% 64.72% +0.05%
==========================================
Files 410 411 +1
Lines 23749 23813 +64
==========================================
+ Hits 15357 15412 +55
- Misses 8392 8401 +9 ☔ View full report in Codecov by Sentry. |
koutst
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch suggester for people (authors, users)
Closes ResearchHub/issues#153