Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version from ComputerLanguage #150

Merged
merged 3 commits into from
May 29, 2023

Conversation

simleo
Copy link
Collaborator

@simleo simleo commented May 19, 2023

This had several problems:

I left the lang_version argument of add_workflow untouched, so it can be used to set the version for the CWL identifier.

UPDATE (2023-05-29): At the latest meeting, some expressed concerns about removing the ability to set the version entirely, so I changed the PR to only remove the arbitrary defaults instead. Note that the identifier for the CWL language is versioned only if a version is provided, as in the original PR.

@simleo simleo merged commit 6a822b3 into ResearchObject:master May 29, 2023
@simleo simleo deleted the rm_lang_version branch May 29, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant