Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue addressed by this PR was reported by @rsirvent. For the following URL:
https://zenodo.org/records/10782431/files/lysozyme_datasets.zip
content-type
(which ends up inencodingFormat
) was being duplicated:application/octet-stream, application/octet-stream
last-modified
was missingApparently the
content-type
duplication is not really an error: the server sendscontent-type
twice andurllib
merges them with a comma, which is consistent with RFC 7230 (see the Requests docs for response headers). However, Requests (and the underlying Urllib3) somehow detects that this is some kind of server error and provides a content-type ofapplication/octet-stream
. With this PR, we use Requests to get the header and avoid the above problems. It is worth noting that the new behavior is consistent withcurl -I
.