Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs #263

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Improve docs #263

merged 2 commits into from
Mar 25, 2020

Conversation

angeliski
Copy link
Contributor

Description

Improvement in docs

How to test?

Just read.

Expected behavior

No English typos

@angeliski angeliski requested a review from megatroom March 24, 2020 22:09
Copy link
Contributor

@megatroom megatroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei algumas sugestões nas suas alterações, e queria sugerir um pequeno ajuste onde você não mexeu mas para já ajustar:

Lá no final tem:

`"The answer is out there, Neo, and it's looking for you, and it will find you if you want it to."`

Trocar para:

> "The answer is out there, Neo, and it's looking for you, and it will find you if you want it to."

Que é a marcação para citação.

A imagem do "Run on Google Cloud" está muito grande, pensei em ajustar para max-width: 200px;, o que acha?

README.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
Copy link
Contributor

@megatroom megatroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@angeliski angeliski merged commit 30c38d6 into master Mar 25, 2020
@angeliski angeliski deleted the docs-readme-improve branch March 25, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants