Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GCP exclusive button branch #280

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

juliemar
Copy link
Contributor

@juliemar juliemar commented Apr 1, 2020

Description

When we created the Google Cloud Run Button There was an incompatibility between app.json for Heroku and GCP.

We reported this problem to google in this issue and they fixed ignoring the stack field in this commit

How to test?

Execute installation with Google 8Cloud Run Button

Expected behavior

everything needs to work well and this problem have to be fixed.

@juliemar juliemar requested review from megatroom and angeliski April 1, 2020 00:59
Copy link
Contributor

@megatroom megatroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@juliemar juliemar merged commit 769c6b7 into master Apr 1, 2020
@juliemar juliemar deleted the remove-gcp-button-branch branch April 1, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants