Merge pull request #8 from Jamiras/feature/vendor_2.1.9

upgrade to official 2.1.9 release

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -0,0 +1,116 @@
+name: Bug Report
+description: If you experience a bug in the Emulator, please open an issue here and fill out the template.
+title: "[Bug]: "
+labels: ["bug", "triage"]
+assignees: 
+  - 
+body:
+  - type: markdown
+    attributes:
+      value: "## BEFORE REPORTING AN ISSUE"      
+  - type: markdown
+    attributes:
+      value: |
+            Please try the nightly build from: https://nightly.vba-m.com and factory resetting the emulator from the Help menu.
+            On Linux build master from source or use the edge snap.
+            And last but not least, search for existing reports via the filters bar on the issues page.
+  - type: markdown
+    attributes:
+      value: "## If your joystick or gamepad isn't working in Linux"      
+  - type: markdown
+    attributes:
+      value: |
+            Please try to troubleshoot using the information on this page:h ttps://wiki.archlinux.org/index.php/Gamepad **BEFORE** filing an issue. 
+            We use SDL for joystick support, any problems will generally be an issue with SDL and **NOT** the emulator.
+            If relevant, the joystick you are using and the drivers you are using for it:          
+  - type: textarea
+    id: what-should-happen
+    attributes:
+      label: Expected behavior?
+      description: How was the emulator supposed to behave
+      placeholder: Tell us what you expect to see!; use screenshots if necessary.
+      value: 
+    validations:
+      required: true
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: Actual behavior?
+      description: Describe the issue you encountered.
+      placeholder: Tell us what you see!; use screenshots if necessary.
+      value: 
+    validations:
+      required: true
+  - type: textarea
+    id: repro
+    attributes:
+      label: Steps to reproduce the problem
+      description: "How do you trigger this bug? Please walk us through it step by step."
+      value: |
+            1.
+            2.
+            3.
+            4.
+            5.
+            ...
+    validations:
+      required: true
+  - type: textarea
+    id: error-messages
+    attributes:
+      label: Error messages?
+      description: Was there an error message?
+      placeholder: List any exception messages here!; use screenshots if necessary.
+      value: |
+            If this is a crash bug, and you have the time and inclination, please provide a symbolic backtrace.
+            Instructions for doing so are [here](https://github.com/visualboyadvance-m/visualboyadvance-m/blob/master/README.md#reporting-crash-bugs).
+    validations:
+      required: false
+  - type: textarea
+    id: Rom_Details
+    attributes:
+      label: What game were you playing
+      description: "What is the specific rom that you encountered an issue with"
+      value: |
+            <Some of this information can be provided with a screenshot of Rom Information, SAVE TYPE for GBA titles can be obtained from Options > Game Boy Advance > Config>
+            Title:
+            GB, GBC or GBA:
+            ROM CODE: 
+            BIOS Used?: (Share crc hash)
+            SAVE TYPE: (Attach Battery or Savestate here)
+            Clean, Intro'd or Hacked?:(Attach Patch here)
+    validations:
+      required: false
+  - type: textarea
+    id: Settings
+    attributes:
+      label: What settings are you using?
+      description: "Please list them"
+      value: |
+            Video driver (simple, opengl):
+            Sound driver (directsound, xaudio, openal, SDL):
+            Scale Filter Used?:
+    validations:
+      required: true
+  - type: textarea
+    id: SysInfo
+    attributes:
+      label: Specifications and Build details
+      description: "List your system information, you can obtain this from MSINFO32 and the emulators Titlebar."
+      value: |
+            VBA-M: (include commit version number and whether you are using the 32-bit or 64-bit version)
+            OS: (include version and OS build number using WinVer if on Windows):
+            If using Linux, specify if using xorg or Wayland:
+            CPU:
+            GPU:
+            RAM:
+    validations:
+      required: true
+  - type: checkboxes
+    id: Copyright_Compliance
+    attributes:
+      label: Copyright Compliance
+      description: Please do not attach any files that infringe on the copyright of Nintendo or its partners.
+      options:
+        - label: There are no infringing files attached to this bug report.
+          required: true

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,9 @@
+blank_issues_enabled: false
+contact_links:
+  - name: VBA-M Forum
+    url: https://board.vba-m.com/
+    about: For general questions and support please join our forum or our
+  - name: VBA-M IRC Channel
+    url: https://web.libera.chat/#vba-m
+    about: For realtime discussion and support
+

.github/ISSUE_TEMPLATE/feature.yml

@@ -0,0 +1,46 @@
+name: Feature request
+description: >-
+  If you would like a new feature in Visual Boy Advance - M, please
+  open an issue here and fill out the template.
+title: '[Feature request]: '
+labels:
+  - enhancement
+assignees:
+  - null
+body:
+  - type: markdown
+    attributes:
+      value: "## BEFORE CREATING A FEATURE REQUEST"      
+  - type: markdown
+    attributes:
+      value: |
+            Please try a nightly build from: https://nightly.vba-m.com to see if your idea has already been implemented.
+            On Linux build master from source or use the edge snap.
+            And last but not least, search for existing requests via the filters bar on the issues page.
+  - type: textarea
+    id: feature-request
+    attributes: 
+      label: Request box
+      description: What feature would you like to see added?
+      placeholder: Tell us what you would like to see added to Visual Boy Advance - M!
+      value: null
+    validations: 
+      required: true
+  - type: textarea
+    id: reason-why
+    attributes: 
+      label: Reason box
+      description: Provide reasoning for the new feature
+      placeholder: Tell us why you'd like to see this feature added
+      value: null
+    validations: 
+      required: true
+  - type: textarea
+    id: Examples
+    attributes: 
+      label: Examples
+      description: Provide examples of this feature
+      placeholder: Provide examples or screenshots of this feature in other software
+      value: null
+    validations: 
+      required: true

.github/workflows/macos-build.yml

@@ -0,0 +1,27 @@
+name: macOS Latest Build
+on: [push, pull_request]
+#on: workflow_dispatch
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        cmake_build: ['-DCMAKE_BUILD_TYPE=Release', '-DCMAKE_BUILD_TYPE=Debug']
+        cmake_options: ['', '-DENABLE_LINK=OFF', '-DENABLE_SDL=ON']
+    runs-on: macos-latest
+
+    steps:
+      - name: Checkout the code
+        uses: actions/checkout@v2
+        with: 
+          submodules: recursive
+      - name: Install nix
+        uses: cachix/install-nix-action@v22
+        with:
+          nix_path: nixpkgs=channel:nixos-unstable
+      - name: Configure
+        run: >-
+          nix-shell --command 'cmake -B build -G Ninja ${{ matrix.cmake_build }} ${{ matrix.cmake_options }}'
+      - name: Build
+        run: >-
+          nix-shell --command 'ninja -C build'

.github/workflows/msys2-build.yml

@@ -1,39 +1,37 @@
-name: MSYS2 Build
-on: [push, pull_request]
-
-jobs:
-  build:
-    runs-on: windows-latest
-    env:
-      MSYSTEM: CLANG64
-    defaults:
-      run:
-        shell: msys2 {0}
-
-    steps:
-      - uses: actions/checkout@v2
-        with: 
-          submodules: true
-
-      - uses: msys2/setup-msys2@v2
-        with:
-          msystem: CLANG64
-          install: >-
-            mingw-w64-clang-x86_64-toolchain
-            mingw-w64-clang-x86_64-pkg-config
-            mingw-w64-clang-x86_64-ffmpeg
-            mingw-w64-clang-x86_64-FAudio
-            mingw-w64-clang-x86_64-cmake
-            mingw-w64-clang-x86_64-ninja
-            mingw-w64-clang-x86_64-wxmsw3.1
-            mingw-w64-clang-x86_64-sfml
-            mingw-w64-clang-x86_64-SDL2
-            zip
-      - name: Configure
-        run: >-
-          cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DENABLE_SDL=ON -DSDL2_STATIC=ON -DSFML_STATIC_LIBRARIES=ON -DFFMPEG_STATIC=ON -DOPENAL_STATIC=ON -DSSP_STATIC=ON -DVBAM_STATIC=ON -DENABLE_SSP=ON -DENABLE_ONLINEUPDATES=OFF
-      - name: Build
-        run: ninja -C build
-
-      - name: Install
-        run: ninja -C build install
+name: MSYS2 Build
+on: [push, pull_request]
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        cmake_build: ['-DCMAKE_BUILD_TYPE=Release', '-DCMAKE_BUILD_TYPE=Debug']
+        cmake_options: ['', '-DENABLE_LINK=OFF', '-DENABLE_SDL=ON']
+    runs-on: windows-latest
+    env:
+      MSYSTEM: CLANG64
+    defaults:
+      run:
+        shell: msys2 {0}
+
+    steps:
+      - name: Checkout the code
+        uses: actions/checkout@v2
+        with: 
+          submodules: recursive
+      - name: Setup msys2
+        uses: msys2/setup-msys2@v2
+        with:
+          msystem: CLANG64
+          update: true
+      - name: Install deps
+        run: >-
+          bash installdeps
+      - name: Configure
+        run: >-
+          cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug ${{ matrix.cmake_build }} ${{ matrix.cmake_options }}
+      - name: Build
+        run: ninja -C build
+
+      - name: Install
+        run: ninja -C build install

.github/workflows/ubuntu-build.yml

@@ -0,0 +1,30 @@
+name: Ubuntu Latest Build
+on: [push, pull_request]
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        cmake_compiler: ['-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++', '-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++']
+        cmake_build: ['-DCMAKE_BUILD_TYPE=Release', '-DCMAKE_BUILD_TYPE=Debug']
+        cmake_options: ['', '-DENABLE_LINK=OFF', '-DENABLE_SDL=ON']
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout the code
+        uses: actions/checkout@v2
+        with: 
+          submodules: recursive
+
+      - name: Install Dependencies
+        run: >-
+          bash installdeps; if [ "${{ matrix.compiler }}" = clang ]; then sudo apt -y install clang; fi
+
+      - name: Configure
+        run: >-
+          cmake -B build -G Ninja ${{ matrix.cmake_compiler }} ${{ matrix.cmake_build }} ${{ matrix.cmake_options }}
+
+      - name: Build
+        run: ninja -C build
+
+      - name: Install
+        run: sudo ninja -C build install