Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gamecube to hash initialize iterator for iso format #353

Merged

Conversation

bozothegeek
Copy link
Contributor

Just to add Gamecube now for 'iso' format in hash initialization for iterator. Thanks in advance for this merge. Tested in pixL (new retro OS ;-)

@bozothegeek
Copy link
Contributor Author

See for example of result when hash matched well now with any new retroarchivements for gamecube in this OS using pegasus-frontend and a modified GameOS theme including RA display...
image

@Jamiras
Copy link
Member

Jamiras commented Jul 17, 2024

Please also update the test_hash_gamecube function to initialize an iterator and validate the new code path.

@Jamiras
Copy link
Member

Jamiras commented Jul 25, 2024

@bozothegeek - have you had a chance to look at the unit test suggestion?

@bozothegeek
Copy link
Contributor Author

@bozothegeek - have you had a chance to look at the unit test suggestion?

OK, I will check... sorry, I just saw your reply ;-)

Add Gamecube to hash initialize iterator for iso format
@bozothegeek bozothegeek force-pushed the add-gamecube-iso-iterator branch from f006c2e to b367d1d Compare August 6, 2024 18:54
@bozothegeek
Copy link
Contributor Author

Hi @Jamiras It's done, I updated the unit test test_hash_gamecube as expected, thanks in advance

@Jamiras Jamiras added this to the 11.6.0 milestone Aug 17, 2024
@Jamiras Jamiras merged commit f1d6965 into RetroAchievements:develop Aug 17, 2024
7 checks passed
@bozothegeek
Copy link
Contributor Author

@Jamiras Thanks ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants