Improve file-system accesses #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a cache for stat checks
pjft
added a commit
that referenced
this pull request
Mar 31, 2021
In #688 the change from getCanonicalPath to getAbsolutePath improved performance, but the case of an empty path was not resolving appropriately for the VLC video player.
aarononeal
reviewed
Feb 2, 2022
There was a problem hiding this comment.
@pjft In the trusted game list case, the file system should not be touched until game load. Without other changes, and relying only on this cache, then most likely mPathExistsIndex needs to be pre-initialized with trusted game list paths in order to avoid the stat64 call here. The stat64 call must be eliminated entirely, not just reduced, in the trusted path in order to address performance against clustered storage or high latency networks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves file-system accesses, especially on remote systems.
Currently there are multiple instances of unnecessary file-system accesses for checking if files exist, including consecutively when updating the UI and loading the assets for each game during navigation.
This implements a quick and dirty index map for such "exists" operations that are somewhat expensive in remote storage scenarios (NAS), averaging 100ms each, causing navigation to be unnecessarily slow.
Also, changed some of the file-system accesses and calculations on the video player front.
If useful I can implement this as an option, but didn't want to over-engineer it. I suppose the only reason that this would not be desired is if the actual files that ES expects to point to actually change in runtime, outside of ES, but since there's also no "re-scan" feature for file-system changes right now, I imagine that this will not be a meaningful issue. Still, happy to consider.