Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gridview: ignore placeholders on metadata updates #715

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

cmitu
Copy link

@cmitu cmitu commented Nov 22, 2020

Similar to

if(!mList.setCursor(cursor) && (!cursor->isPlaceHolder()))
.

Prevents ES crashing when trying to update metadata on a placeholder value, like the 1st entry on an empty custom collection.

@cmitu cmitu requested a review from pjft November 22, 2020 05:09
@pjft
Copy link
Collaborator

pjft commented Nov 24, 2020

Thank you - of course! When these were added, Grid had already been started, but as it wasn't working I didn't add these there. There might be more missing.

@tomaz82 tomaz82 merged commit dc1ebc8 into RetroPie:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants