lock unreliable channel only if there is pending packets

RevenantX · Aug 3, 2024 · 265487d · 265487d
1 parent 5124524
commit 265487d
Showing 1 changed file with 15 additions and 12 deletions.
diff --git a/LiteNetLib/NetPeer.cs b/LiteNetLib/NetPeer.cs
@@ -1406,19 +1406,22 @@ internal void Update(float deltaTime)
                     _channelSendQueue.Enqueue(channel);
                 }
             }
-
-            int unreliableCount;
-            lock (_unreliableChannelLock)
+
+            if (_unreliablePendingCount > 0)
             {
-                (_unreliableChannel, _unreliableSecondQueue) = (_unreliableSecondQueue, _unreliableChannel);
-                unreliableCount = _unreliablePendingCount;
-                _unreliablePendingCount = 0;
-            }
-            for (int i = 0; i < unreliableCount; i++)
-            {
-                var packet = _unreliableSecondQueue[i];
-                SendUserData(packet);
-                NetManager.PoolRecycle(packet);
+                int unreliableCount;
+                lock (_unreliableChannelLock)
+                {
+                    (_unreliableChannel, _unreliableSecondQueue) = (_unreliableSecondQueue, _unreliableChannel);
+                    unreliableCount = _unreliablePendingCount;
+                    _unreliablePendingCount = 0;
+                }
+                for (int i = 0; i < unreliableCount; i++)
+                {
+                    var packet = _unreliableSecondQueue[i];
+                    SendUserData(packet);
+                    NetManager.PoolRecycle(packet);
+                }
             }
 
             SendMerged();