Remove references to deprecated v1 Android embedding

[reidbaker]

• I have updated Purchases SDK to the latest version
• I have read the Contribution Guidelines
• I have searched the Community
• I have read docs.revenuecat.com
• I have searched for existing Github issues

‼️ Required data ‼️

Do not remove any of the steps from the template below. If a step is not applicable to your issue, please leave that step empty.

There are a lot of things that can contribute to things not working. Having a very basic understanding of your environment will help us understand your issue faster!

Environment

• Output of flutter doctor Future version of flutter
• Version of purchases-flutter 7.0.1
• Testing device version e.g.: iOS 15.5, Android API 30, etc. All Android
• How often the issue occurs- every one of your customers is impacted? Only in dev? 100%
• Debug logs that reproduce the issue N/A
• Steps to reproduce, with a description of expected vs. actual behavior See below
  Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)

Describe the bug

Remove references to deprecated v1 Android embedding

To ensure this plugin will work with users running the next stable version of Flutter remove references to the v1 embedding.

The v1 embedding was deprecated around 6 and a half years ago. In Flutter 3.22, the Flutter tool dropped support for building v1 apps entirely. Flutter plans to delete version one of it's Android embedding in the next stable release, per https://medium.com/flutter/whats-new-in-flutter-3-22-fbde6c164fe3 (in the "Removal of v1 Android embedding" section).

When that deletion happens, any apps using plugins that still have references to the removed classes will fail to build when updating to the next stable version (probably Flutter 3.26).

As a part of this deprecation, the Flutter Android team is doing community outreach by filing bugs and submitting some pull requests to update plugins to minimize the impact this removal has on the community.

Some example PRs:

• Flutter team maintained plugins: [many] Remove references to v1 embedding flutter/packages#6494
• android_alarm_manager_plus fix(android_alarm_manager_plus): Remove references to v1 embedding fluttercommunity/plus_plugins#2864

Consequences:

• This change should have no impact on users of this plugin that are building apps using the v2 embedding (we don't have a percentage to share, but this is the vast majority of users).
• It will remove support for users that are still using the v1 embedding on versions of Flutter older than 3.22.

If this change doesn't land, this plugin will instead be broken for all apps building on the next stable version of Flutter and beyond.

Is there a way to support both v1 and v2 embedding apps in the next stable version of Flutter?

No.

This is the PR where we are removing the deprecated engine classes: flutter/engine#52022

[RCGitBot]

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

[Jethro87]

@reidbaker Thanks for the heads up!

[tonidero]

Hi @reidbaker thanks for letting us know! We started working on this. Can you provide a high-level approximated timeline of when you plan to release that change?

[reidbaker]

We plan to merge that pr in ~september which would impact master immediately, beta ~2-3 weeks later and stable in november.

The primary argument for doing this faster is that more of your customers will naturally pick up the change. I will leave it to you to determine the urgency but you have some time before your customers are stuck.

[tonidero]

This was addressed in #1141 and will be released in 8.0.0. Thanks for letting us know! Will close this since it should be addressed

[reidbaker]

I double checked and it looks like #1141 fixed this for your users. You have one reference in a comment remaining but I don't think that is a big deal.
https://github.com/search?q=repo%3ARevenueCat%2Fpurchases-flutter%20(%22io.flutter.view.FlutterMain%22%20OR%20%22io.flutter.view.FlutterNativeView%22%20OR%20%22io.flutter.view.FlutterView%22%20OR%20%22io.flutter.embedding.engine.plugins.shim%22%20OR%20%22io.flutter.app%22%20OR%20%22PluginRegistry.Registrar%22)&type=code