Refine StoreKitVersion logging in configure function #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-at-will
changed the title
fire-at-will
added
pr:feat
|
I've used the "fix" tag here since "feat" didn't feel appropriate - let me know if y'all think there's a better tag to use so the release notes come out correct! |
tonidero
approved these changes
Aug 19, 2024
Merged
tonidero
added a commit
that referenced
this pull request
Aug 22, 2024
### Breaking Changes * Remove embedding v1 support (#1141) via Toni Rico (@tonidero) If you're using embedding v1, please check how to migrate in the [official flutter docs](https://docs.flutter.dev/release/breaking-changes/plugin-api-migration#upgrade-steps). ### Bugfixes * Refine StoreKitVersion logging in configure function (#1143) via Will Taylor (@fire-at-will) ### Other Changes * v7-MIGRATION.md typo fix (#1144) via Will Taylor (@fire-at-will)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the logging related to the
storeKitVersionin theconfigure()function. Specifically, it:storeKitVersionparam is not the default value. This should prevent confusion in the event that a developer passes in aPurchasesAreCompletedByMyAppbut doesn't pass in astoreKitVersionparamstoreKitVersionpassed intoPurchasesAreCompletedByMyAppis the default value, it logs a warning letting the developer know that they should provide a specificstoreKitVersionthat matches what they're using in their StoreKit implementation.